lkml.org 
[lkml]   [2010]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [COUNTERPATCH] mm: avoid overflowing preempt_count() in mmu_take_all_locks()
On Thu, Apr 01, 2010 at 07:02:51PM +0300, Avi Kivity wrote:
> Not these locks, but if we go all the way and make mmu notifiers
> sleepable, we can convert mmu_lock to a mutex.

Ah yes, sure! I didn't get the objective was to convert the kvm
mmu_lock to mutex too, I thought you were talking about the linux VM
locks, and of course with rmap walks you meant the kvm rmaps, not the
linux rmaps. It's all clear now sorry.

I guess I was biased because I see mmu_lock like the page_table_lock
and in linux we never had mutex protecting pagetable access, because
pagetable mangling is so quick and never blocks. But there are the
rmap walks too protected by the same mmu_lock in kvm (not the case for
the page_table_lock that only protects pagetable access), so I agree
it may be worth converting it to mutex, agreed.


\
 
 \ /
  Last update: 2010-04-01 18:15    [W:0.089 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site