lkml.org 
[lkml]   [2010]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl
On Tue, Mar 09, 2010 at 03:32:06PM -0800, Joe Perches wrote:
> There was an article published recently:
> http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> that seems to have prompted several new contributors (welcome)
> to create style reformatting patches.
>
> The article recommends running checkpatch and fixing the various
> non-conforming style elements the output produces.
>
> A better solution might be to enhance checkpatch to rewrite the
> patch or a file with -f, but that's more than I'd like to do.

I _really_ dislike automatic source conversions by a tool and do not
recommend doing that at all.

It's better that you look at the code yourself, and make the change that
looks correct, which is not always the same thing that an automated tool
would do.

Becides, we have the Lindent script, which does almost exactly what you
are trying to do here, why reinvent the wheel?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-03-10 00:45    [W:0.104 / U:1.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site