Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device | Date | Tue, 9 Mar 2010 21:12:13 +0100 |
| |
On Tuesday 09 March 2010, Thadeu Lima de Souza Cascardo wrote: > MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>"); > @@ -1881,7 +1880,7 @@ static int input_open_file(struct inode *inode, struct file *file) > const struct file_operations *old_fops, *new_fops = NULL; > int err; > > - lock_kernel(); > + mutex_lock(&input_mutex); > /* No load-on-demand here? */ > handler = input_table[iminor(inode) >> 5]; > if (!handler || !(new_fops = fops_get(handler->fops))) { > @@ -1909,7 +1908,7 @@ static int input_open_file(struct inode *inode, struct file *file) > } > fops_put(old_fops); > out: > - unlock_kernel(); > + mutex_unlock(&input_mutex); > return err; > } > > --
Well, actually please have a look at http://git.kernel.org/?p=linux/kernel/git/arnd/playground.git;a=commitdiff;h=c06fd0234357618a5741ce958d58901ae4cb7ac1
* use mutex_lock_interruptible() where possible * you probably don't want to hold input_mutex when calling into the lower device's open function
Arnd
| |