Messages in this thread | | | Date | Tue, 09 Mar 2010 14:16:30 -0500 | From | James Kosin <> | Subject | Re: [PATCH] Security: key: keyring: fix code style issues |
| |
On 3/9/2010 2:10 PM, Chihau Chau wrote: > From: Chihau Chau <chihau@gmail.com> > > This fixes to include <linux/uaccess.h> instead <asm/uaccess.h> and some > code style issues like to put a else sentence below close brace '}' and > to replace a tab instead of some space characters. > > Signed-off-by: Chihau Chau <chihau@gmail.com>
Reviewed-by: James Kosin <jkosin@intcomgrp.com>
> --- > security/keys/keyring.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/security/keys/keyring.c b/security/keys/keyring.c > index e814d21..d8b5d5e 100644 > --- a/security/keys/keyring.c > +++ b/security/keys/keyring.c > @@ -17,7 +17,7 @@ > #include <linux/seq_file.h> > #include <linux/err.h> > #include <keys/keyring-type.h> > -#include <asm/uaccess.h> > +#include <linux/uaccess.h> > #include "internal.h" > > /* > @@ -172,8 +172,7 @@ static void keyring_describe(const struct key *keyring, struct seq_file *m) > > if (keyring->description) { > seq_puts(m, keyring->description); > - } > - else { > + } else { > seq_puts(m, "[anon]"); > } > > @@ -306,7 +305,7 @@ key_ref_t keyring_search_aux(key_ref_t keyring_ref, > key_check(keyring); > > /* top keyring must have search permission to begin the search */ > - err = key_task_permission(keyring_ref, cred, KEY_SEARCH); > + err = key_task_permission(keyring_ref, cred, KEY_SEARCH); > if (err < 0) { > key_ref = ERR_PTR(err); > goto error; > @@ -775,8 +774,7 @@ int __key_link(struct key *keyring, struct key *key) > smp_wmb(); > klist->nkeys++; > smp_wmb(); > - } > - else { > + } else { > /* grow the key list */ > max = 4; > if (klist)
| |