lkml.org 
[lkml]   [2010]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] HID: N-trig MTM Driver fix And cleanup patch 7
On Mon, Mar 08, 2010 at 11:17:04PM +0200, mickib1@gmail.com wrote:
> + case REPORT_GENERIC2:
> + if ((X_CORD_VAL == nd->x_cord) && (Y_CORD_VAL == nd->y_cord) &&
> + (DX_CORD_VAL == nd->dx) && (DY_CORD_VAL == nd->dy) &&
> + (GENERIC_BYTE_VAL == value)) {
> + if (MAX_FINGERS_SUPPORT == nd->fake_fingers--) {
> + input_report_abs(input, ABS_MT_TOOL_TYPE, MT_TOOL_FINGER);
> + input_report_abs(input, ABS_MT_TRACKING_ID, END_OF_REPORT);
> + input_event(input, EV_MSC, MSC_SCAN, nd->frame_index);

EV_MSC/MSC_SCAN is to be used to communicate scancodes or their
equivalents for the corresponsing KEV_KEY/KEY_xxx to userspace.

> + input_sync(input);
> + ntrig_dbg("Session Sync Frame %x\n", nd->frame_index);
> + } else
> + ntrig_dbg("Fake Finger %x\n", nd->frame_index);
> + } else {
> + input_report_abs(input, ABS_MT_TOOL_TYPE, MT_TOOL_FINGER);
> + input_report_abs(input, ABS_MT_TRACKING_ID, nd->finger_id);
> + input_report_abs(input, ABS_MT_POSITION_X, nd->x_cord);
> + input_report_abs(input, ABS_MT_POSITION_Y, nd->y_cord);
> + input_report_abs(input, ABS_MT_TOUCH_MAJOR, nd->dx);
> + input_report_abs(input, ABS_MT_TOUCH_MINOR, nd->dy);
> + input_event(input, EV_MSC, MSC_PULSELED, nd->generic_byte);

No, you are not pulsing the led here. Please do not overload the events
with your application-specific usage.

New events might be allocated, but the need for them must be articulated
on a purely technical basis.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2010-03-09 19:53    [W:0.064 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site