Messages in this thread | | | Date | Mon, 08 Mar 2010 17:42:58 +0900 | From | Akira Fujita <> | Subject | Re: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode |
| |
Hi Christian,
(2010/03/08 5:32), Christian Borntraeger wrote: > I have an x86_64 kernel with i386 userspace. e4defrag fails on the > EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat > case. It seems that struct move_extent is compat save, only types > with fixed widths are used: > { > __u32 reserved; /* should be zero */ > __u32 donor_fd; /* donor file descriptor */ > __u64 orig_start; /* logical start offset in block for orig */ > __u64 donor_start; /* logical start offset in block for donor */ > __u64 len; /* block length to be moved */ > __u64 moved_len; /* moved block length */ > }; > > Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. > > Signed-off-by: Christian Borntraeger<borntraeger@de.ibm.com> > CCed: Akira Fujita<a-fujita@rs.jp.nec.com> > > --- > fs/ext4/ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file > break; > case EXT4_IOC_GROUP_ADD: > break; > + case EXT4_IOC_MOVE_EXT: > + break; > default: > return -ENOIOCTLCMD; > }
Looks good for me. Thank you for your work.
Regards, Akira Fujita
| |