lkml.org 
[lkml]   [2010]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] stop_machine: reimplement using cpuhog
On 03/09, Tejun Heo wrote:
>
> int __stop_machine(int (*fn)(void *), void *data, const struct cpumask *cpus)
> {
> ...
> + /* Set the initial state and hog all online cpus. */
> + set_state(&smdata, STOPMACHINE_PREPARE);
> + return hog_cpus(cpu_online_mask, stop_cpu, &smdata);
> }

Could you please confirm this is correct?

I am not sure I understand how the code looks with the patch applied,
but the lockless set_state() above can confuse another stop_machine()
in progress?

Oleg.



\
 
 \ /
  Last update: 2010-03-08 20:11    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean