lkml.org 
[lkml]   [2010]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: musb: fix build error introduced by isoc change
On Mon, Mar 08, 2010 at 10:01:45PM +0530, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
> >
> > From: Sonic Zhang <sonic.zhang@analog.com>
> >
> > The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> > seems to have been against an older kernel version. It uses the old style
> > naming of variables. Unfortunately, this breaks building for most MUSB
> > users out there since "bDesiredMode" has been renamed to "desired_mode".
> >
>
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds. Felipe's upcoming patches
> would make this code redundant anyway.
>
> Till then, we might as well fix it.

yes, it was my bad. I should have reviewed the code more carefully. We
will be testing the mode1 support on DaVinci during this and the next
week and when we get it working, we will publish the mode1 dma changes
again which will completely change this code.

> > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Acked-by: Anand Gadiyar <gadiyar@ti.com>

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

--
balbi


\
 
 \ /
  Last update: 2010-03-08 19:37    [W:0.066 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site