Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH,RESEND -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init() | Date | Mon, 08 Mar 2010 13:19:28 +0000 |
| |
Oleg Nesterov <oleg@redhat.com> wrote:
> (on top of kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch) > > call_usermodehelper_keys() uses call_usermodehelper_setkeys() to change > subprocess_info->cred in advance. Now that we have info->init() we can > change this code to set tgcred->session_keyring in context of execing > kernel thread. > > Note: since currently call_usermodehelper_keys() is never called with > UMH_NO_WAIT, call_usermodehelper_keys()->key_get() and umh_keys_cleanup() > are not really needed, we could rely on install_session_keyring_to_cred() > which does key_get() on success. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: David Howells <dhowells@redhat.com>
| |