Messages in this thread | | | Date | Thu, 4 Mar 2010 23:29:28 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/3] device.h drivers/base/core.c Convert dev_<level> macros to functions |
| |
On Thu, 04 Mar 2010 23:23:35 -0800 Joe Perches <joe@perches.com> wrote:
> On Thu, 2010-03-04 at 23:10 -0800, Andrew Morton wrote: > > On Thu, 4 Mar 2010 22:56:53 -0800 Joe Perches <joe@perches.com> wrote: > > > Perhaps over time the struct and local uses of dev_info should be renamed. > > aww, c'mon. > > y:/usr/src/linux-2.6.33> grep -r '\*dev_info;' . | wc -l > > 30 > > No doubt I could submit all the required changes in > an hour or so, but some of the maintainers seem > less than open to what they consider "churn".
Well, that has to be one of the worst possible reasons?
> $ grep -rP --include=*.[ch] -l "dev_info\b\s*[^\(]" * > arch/powerpc/platforms/iseries/dt.c > drivers/usb/host/xhci-dbg.c > drivers/usb/host/xhci.h > drivers/usb/wusbcore/wusbhc.h > drivers/scsi/scsi_devinfo.c > drivers/staging/comedi/drivers/das08_cs.c > drivers/staging/comedi/drivers/ni_daq_dio24.c > drivers/staging/comedi/drivers/quatech_daqp_cs.c > drivers/staging/comedi/drivers/ni_daq_700.c > drivers/staging/comedi/drivers/ni_labpc_cs.c > drivers/staging/comedi/drivers/cb_das16_cs.c > drivers/staging/udlfb/udlfb.c > drivers/media/video/sh_mobile_ceu_camera.c > drivers/md/linear.h > drivers/net/ksz884x.c > drivers/net/bnx2x_link.c > drivers/net/wireless/wl3501_cs.c > drivers/net/cnic.c > drivers/net/bnx2x_main.c > include/linux/sfi.h > include/net/bluetooth/rfcomm.h
Send 'em over, please. I'll merge any stragglers directly.
| |