lkml.org 
[lkml]   [2010]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] genirq: spurious irq detection for threaded irqs
On Fri, 5 Mar 2010, Uwe Kleine-König wrote:

> For threaded irqs the top half returns IRQ_WAKE_THREAD. Don't treat
> that value like IRQ_HANDLED for the spurious check. Instead check the
> return value of the threaded handler to be able to detect stuck irqs
> that only have threaded handlers and no top half that can detect the
> problem.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> ---
> Hello,
>
> changed since v1:
>
> - use note_interrupt for the threaded handler's return value, getting rid of
> note_threaded_interrupt. The only downside is that a threaded handler
> returning IRQ_WAKE_THREAD remains uncatched now.

Well that's easy to fix.

> + if (!noirqdebug)
> + note_interrupt(action->irq, desc, action_ret);

note_interrupt(action->irq, desc,
action_ret & ~IRQ_WAKE_THREAD);
Thanks,

tglx
\
 
 \ /
  Last update: 2010-03-05 21:21    [W:1.101 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site