lkml.org 
[lkml]   [2010]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/2] x86: Manage ENERGY_PERF_BIAS based on cpufreq governor - v2
On Thu, Mar 04, 2010 at 03:14:56PM -0800, Venki Pallipadi wrote:

> + if (!strncmp(gov->name, "performance", strlen("performance")))
> + epb_val = ENERGY_PERF_BIAS_PERF;
> + else if (!strncmp(gov->name, "powersave", strlen("powersave")))
> + epb_val = ENERGY_PERF_BIAS_POWER;
> + else
> + epb_val = ENERGY_PERF_BIAS_ONDEMAND;
> +
> + set_epb_on_cpu(epb_val, cpu);
> + return 0;

hardcoding a list of cpufreq governors is kinda icky, but I don't have
a better solution. We'll just have to be mindful of it if we ever
get around to finally making performance/powersave personalities
of ondemand as was discussed years ago.

What if the governor is set to 'userspace' ?
powernowd/cpufreqd are sort of ondemand-done-in-userspace, but there
may also be other userspace governors we don't know about.
I suppose it's not catastrophic..

Dave



\
 
 \ /
  Last update: 2010-03-05 00:31    [W:0.059 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site