lkml.org 
[lkml]   [2010]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Stable-review] [007/116] tg3: Fix 5906 transmit hangs
    On Wed, Mar 31, 2010 at 01:39:26PM -0700, Greg KH wrote:
    > On Tue, Mar 30, 2010 at 09:15:22PM -0400, Chuck Ebbert wrote:
    > > On Tue, 30 Mar 2010 15:54:45 -0700
    > > Greg KH <gregkh@suse.de> wrote:
    > >
    > > > 2.6.32-stable review patch. If anyone has any objections, please let
    > > > us know.
    > > >
    > > > ------------------
    > > >
    > > > From: Matt Carlson <mcarlson@broadcom.com>
    > > >
    > > > This is a resubmit backport of commit
    > > > 92c6b8d16a36df3f28b2537bed2a56491fb08f11 to kernel version 2.6.32.
    > > > The gentoo bug report can be found at
    > > > https://bugs.gentoo.org/show_bug.cgi?id=301091. Thanks to Matt
    > > > Carlson for his assistance and working me to fix a regression caused
    > > > by the initial patch. The original description is as follows:
    > > >
    > >
    > > I think these two patches should be used instead, as they fix the
    > > bug without needing backports and keep the driver closer to upstream:
    > >
    > > 0e1406dd404ce55dbe8d68b4b5e2aed7e5c75fdb
    > > "tg3: Assign flags to fixes in start_xmit_dma_bug"
    > >
    > > 92c6b8d16a36df3f28b2537bed2a56491fb08f11
    > > "tg3: Fix 5906 transmit hangs"
    >
    > I don't know, I'll defer to Matt here, this patch has gone in and out of
    > the stable queue for a while now as he and some users have tested and
    > had problems lots of times...
    >
    > Matt?

    I'm O.K. with either path. I supported Mike's patch because it was
    minimal. (All the bugs should be shaken out by now.) If that isn't a
    goal, then I guess I'd rather rubber stamp my own implementation.



    \
     
     \ /
      Last update: 2010-03-31 23:41    [W:4.242 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site