lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers:staging: sources for ST core
On Wed, 31 Mar 2010, Pavan Savoy wrote:
> +bool is_protocol_list_empty(void)
> +{
> + unsigned char i = 0;
> + pr_debug(" %s ", __func__);

You need to add terminating '\n's to most all these messages.
It's also not necessary to have leading or trailing whitespace.

> +#ifdef VERBOSE
> + printk(KERN_ERR "start data..\n");
> + for (i = 0; i < count; i++) /* no newlines for each datum */
> + printk(" %x", data[i]);
> + printk(KERN_ERR "\n ..end data\n");
> +#endif

print_hex_dump(KERN_ERR, "data: ", DUMP_PREFIX_OFFSET, 16, 1,
data, count, true);

cheers, Joe



\
 
 \ /
  Last update: 2010-03-31 04:27    [W:0.404 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site