Messages in this thread | | | Date | Tue, 30 Mar 2010 18:24:01 -0800 (PST) | From | Joe Perches <> | Subject | Re: [PATCH] drivers:staging: sources for ST core |
| |
On Wed, 31 Mar 2010, Pavan Savoy wrote: > +bool is_protocol_list_empty(void) > +{ > + unsigned char i = 0; > + pr_debug(" %s ", __func__);
You need to add terminating '\n's to most all these messages. It's also not necessary to have leading or trailing whitespace.
> +#ifdef VERBOSE > + printk(KERN_ERR "start data..\n"); > + for (i = 0; i < count; i++) /* no newlines for each datum */ > + printk(" %x", data[i]); > + printk(KERN_ERR "\n ..end data\n"); > +#endif
print_hex_dump(KERN_ERR, "data: ", DUMP_PREFIX_OFFSET, 16, 1, data, count, true);
cheers, Joe
| |