[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[07/89] cciss: Make cciss_seq_show handle holes in the h->drv[] array
2.6.31-stable review patch.  If anyone has any objections, please let us know.


From: Stephen M. Cameron <>

commit 531c2dc70d339c5dfa8c3eb628c3459dc6f3a075 upstream.

It is possible (and expected) for there to be holes in the h->drv[]
array, that is, some elements may be NULL pointers. cciss_seq_show
needs to be made aware of this possibility to avoid an Oops.

To reproduce the Oops which this fixes:

1) Create two "arrays" in the Array Configuratino Utility and
several logical drives on each array.
2) cat /proc/driver/cciss/cciss* in an infinite loop
3) delete some of the logical drives in the first "array."

Signed-off-by: Stephen M. Cameron <>
Signed-off-by: Jens Axboe <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/block/cciss.c | 3 +++
1 file changed, 3 insertions(+)

--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -323,6 +323,9 @@ static int cciss_seq_show(struct seq_fil
if (*pos > h->highest_lun)
return 0;

+ if (drv == NULL) /* it's possible for h->drv[] to have holes. */
+ return 0;
if (drv->heads == 0)
return 0;

 \ /
  Last update: 2010-03-31 02:37    [W:0.668 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site