lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[19/89] edac: i5000_edac critical fix panic out of bounds
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Tamas Vincze <tom@vincze.org>

    commit 118f3e1afd5534c15f9701f33514186cfc841a27 upstream.

    EDAC MC0: INTERNAL ERROR: channel-b out of range (4 >= 4)
    Kernel panic - not syncing: EDAC MC0: Uncorrected Error (XEN) Domain 0 crashed: 'noreboot' set - not rebooting.

    This happens because FERR_NF_FBD bit 28 is not updated on i5000. Due to
    that, both bits 28 and 29 may be equal to one, returning channel = 3. As
    this value is invalid, EDAC core generates the panic.

    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14568

    Signed-off-by: Tamas Vincze <tom@vincze.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Doug Thompson <dougthompson@xmission.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/edac/i5000_edac.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    --- a/drivers/edac/i5000_edac.c
    +++ b/drivers/edac/i5000_edac.c
    @@ -577,7 +577,13 @@ static void i5000_process_nonfatal_error
    debugf0("\tUncorrected bits= 0x%x\n", ue_errors);

    branch = EXTRACT_FBDCHAN_INDX(info->ferr_nf_fbd);
    - channel = branch;
    +
    + /*
    + * According with i5000 datasheet, bit 28 has no significance
    + * for errors M4Err-M12Err and M17Err-M21Err, on FERR_NF_FBD
    + */
    + channel = branch & 2;
    +
    bank = NREC_BANK(info->nrecmema);
    rank = NREC_RANK(info->nrecmema);
    rdwr = NREC_RDWR(info->nrecmema);



    \
     
     \ /
      Last update: 2010-03-31 02:33    [W:2.343 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site