lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[049/116] gigaset: prune use of tty_buffer_request_room
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Tilman Schmidt <tilman@imap.cc>

    commit 873a69a358a6b393fd8d9d92e193ec8895cac4d7 upstream.

    Calling tty_buffer_request_room() before tty_insert_flip_string()
    is unnecessary, costs CPU and for big buffers can mess up the
    multi-page allocation avoidance.

    Signed-off-by: Tilman Schmidt <tilman@imap.cc>
    Acked-by: Karsten Keil <keil@b1-systems.de>
    CC: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/isdn/gigaset/interface.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/isdn/gigaset/interface.c
    +++ b/drivers/isdn/gigaset/interface.c
    @@ -635,7 +635,6 @@ void gigaset_if_receive(struct cardstate
    if ((tty = cs->tty) == NULL)
    gig_dbg(DEBUG_ANY, "receive on closed device");
    else {
    - tty_buffer_request_room(tty, len);
    tty_insert_flip_string(tty, buffer, len);
    tty_flip_buffer_push(tty);
    }



    \
     
     \ /
      Last update: 2010-03-31 02:09    [W:2.066 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site