lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[096/156] softlockup: Stop spurious softlockup messages due to overflow
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 8c2eb4805d422bdbf60ba00ff233c794d23c3c00 upstream.

    Ensure additions on touch_ts do not overflow. This can occur
    when the top 32 bits of the TSC reach 0xffffffff causing
    additions to touch_ts to overflow and this in turn generates
    spurious softlockup warnings.

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Eric Dumazet <eric.dumazet@gmail.com>
    LKML-Reference: <1268994482.1798.6.camel@lenovo>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/softlockup.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/kernel/softlockup.c
    +++ b/kernel/softlockup.c
    @@ -155,11 +155,11 @@ void softlockup_tick(void)
    * Wake up the high-prio watchdog task twice per
    * threshold timespan.
    */
    - if (now > touch_ts + softlockup_thresh/2)
    + if (time_after(now - softlockup_thresh/2, touch_ts))
    wake_up_process(per_cpu(softlockup_watchdog, this_cpu));

    /* Warn about unreasonable delays: */
    - if (now <= (touch_ts + softlockup_thresh))
    + if (time_before_eq(now - softlockup_thresh, touch_ts))
    return;

    per_cpu(softlockup_print_ts, this_cpu) = touch_ts;



    \
     
     \ /
      Last update: 2010-03-31 01:39    [W:3.348 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site