lkml.org 
[lkml]   [2010]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[054/156] tmpfs: mpol=bind:0 dont cause mount error.
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

    commit d69b2e63e9172afb4d07c305601b79a55509ac4c upstream.

    Currently, following mount operation cause mount error.

    % mount -t tmpfs -ompol=bind:0 none /tmp

    Because commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
    shmem_sb_info) corrupted MPOL_BIND parse code.

    This patch restore the needed one.

    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Ravikiran Thirumalai <kiran@scalex86.org>
    Cc: Christoph Lameter <cl@linux-foundation.org>
    Cc: Mel Gorman <mel@csn.ul.ie>
    Acked-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
    Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    mm/mempolicy.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    --- a/mm/mempolicy.c
    +++ b/mm/mempolicy.c
    @@ -2194,9 +2194,13 @@ int mpol_parse_str(char *str, struct mem
    if (!nodelist)
    err = 0;
    goto out;
    - /*
    - * case MPOL_BIND: mpol_new() enforces non-empty nodemask.
    - */
    + case MPOL_BIND:
    + /*
    + * Insist on a nodelist
    + */
    + if (!nodelist)
    + goto out;
    + err = 0;
    }

    mode_flags = 0;



    \
     
     \ /
      Last update: 2010-03-31 01:23    [W:4.094 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site