Messages in this thread Patch in this message | | | Date | Tue, 30 Mar 2010 15:41:19 -0700 | From | Greg KH <> | Subject | [045/156] gigaset: prune use of tty_buffer_request_room |
| |
2.6.33-stable review patch. If anyone has any objections, please let us know.
------------------
From: Tilman Schmidt <tilman@imap.cc>
commit 873a69a358a6b393fd8d9d92e193ec8895cac4d7 upstream.
Calling tty_buffer_request_room() before tty_insert_flip_string() is unnecessary, costs CPU and for big buffers can mess up the multi-page allocation avoidance.
Signed-off-by: Tilman Schmidt <tilman@imap.cc> Acked-by: Karsten Keil <keil@b1-systems.de> CC: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/isdn/gigaset/interface.c | 1 - 1 file changed, 1 deletion(-)
--- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c @@ -632,7 +632,6 @@ void gigaset_if_receive(struct cardstate if (tty == NULL) gig_dbg(DEBUG_ANY, "receive on closed device"); else { - tty_buffer_request_room(tty, len); tty_insert_flip_string(tty, buffer, len); tty_flip_buffer_push(tty); }
| |