Messages in this thread | | | Date | Tue, 30 Mar 2010 08:50:48 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/6] procfs: Kill BKL in llseek on proc base |
| |
On Tue, Mar 30, 2010 at 09:40:24AM +0300, Alexey Dobriyan wrote: > On Tue, Mar 30, 2010 at 9:20 AM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > > --- a/fs/proc/base.c > > +++ b/fs/proc/base.c > > @@ -728,6 +728,7 @@ out_no_task: > > > > static const struct file_operations proc_info_file_operations = { > > .read = proc_info_read, > > + .llseek = generic_file_llseek, > > There is no warning for default default_llseek case. > This should be done same way as proc ioctls.
I don't think we should. We have overriden the llseek for the procfs users located in the proc core (just fs/proc) but we haven't touched all of the external users, and since there are hundreds of them, I guess a lot don't implement llseek.
We would need to first override those that are visible upstream and warn for the further ones after this step only.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |