Messages in this thread | | | Date | Tue, 30 Mar 2010 14:30:30 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 03/24] usb/otg/isp1301_omap: Fix dangling pointer |
| |
On Sat, Mar 20, 2010 at 10:09:07PM +0200, Felipe Balbi wrote: > On Sat, Mar 20, 2010 at 03:12:44PM +0100, Wolfram Sang wrote: > > Fix this i2c-driver which missed setting clientdata to NULL before freeing the > > structure it points to. Found by a semantic patch, but fixed by hand. > > > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> > > Cc: David Brownell <dbrownell@users.sourceforge.net> > > Cc: Greg Kroah-Hartman <gregkh@suse.de> > > Acked-by: Felipe Balbi <felipe.balbi@nokia.com> > > Greg, > > if you wish, you can take queue it already unless Dave has any comments.
Thanks but:
please drop this this patch. We reached an agreement that a) setting the clientdata-pointer to NULL should be done in the i2c-core [1] and b) how to do it. Based on that, I will do the modification of the i2c-core for 2.6.34 (as it fixes the dangling pointers) and then create one single patch removing the then superflous calls to i2c_set_clientdata for 2.6.35 (as it is a cleanup). If you already applied the above patch to your branch, you don't have to revert; we will fix it for you in the next round.
Sorry for the detour!
Kind regards,
Wolfram
[1] http://thread.gmane.org/gmane.linux.drivers.i2c/5674/focus=5729
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |