Messages in this thread | | | Date | Thu, 4 Mar 2010 04:18:47 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -next] bridge: depends on INET |
| |
* David Miller <davem@davemloft.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net> > Date: Tue, 02 Mar 2010 09:08:23 -0800 > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > br_multicast calls ip_send_check(), so it should depend on INET. > > > > built-in: > > br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' > > > > or modular: > > ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Applied, but I almost lost this patch. > > You need to CC: netdev on all networking patches so that it > gets properly tracked in patchwork and therefore does not get > lost.
I suspect Randy went by the MAINTAINERS entry - you might want to add netdev as a second 'L:' line:
ETHERNET BRIDGE M: Stephen Hemminger <shemminger@linux-foundation.org> L: bridge@lists.linux-foundation.org W: http://www.linux-foundation.org/en/Net:Bridge S: Maintained F: include/linux/netfilter_bridge/ F: net/bridge/
To make it really clear that netdev must be Cc:-ed for those patches.
Thanks,
Ingo
| |