lkml.org 
[lkml]   [2010]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 0/11] ahci: Add support for non-PCI devices
    On Wed, Mar 03, 2010 at 08:40:30AM -0500, Jeff Garzik wrote:
    [...]
    > Well, the general idea is to have a kernel module libahci.ko, upon
    > which ahci.ko, mv-ahci.ko, acard-ahci.ko and platform-ahci.ko
    > depends.

    Yep, that's exactly the purpose of my patches.

    > That would imply a bunch of exports, when the library code
    > is moved from ahci.c to libahci.c, because libahci should be a
    > separate kernel module.

    Yep. Though, I don't bother with exporting symbols that neither
    ahci (PCI driver) nor platform driver need. Later we might export
    some more for mv/acard-ahci...

    > I'm not overly picky about file naming. However, in existing
    > installations, people, scripts, knowledgebase articles and
    > configuration files expect "ahci" to be the driver for PCI AHCI
    > devices. We don't want to break that if we can avoid it. Simply
    > using a different name avoids any breakage related to name changes.

    OK. So in these series:

    - I kept PCI driver in ahci.c (built as ahci.ko);
    - Moved generic code into libahci.{c,h} (built as libahci.ko)

    Also in these series:

    - Rebased on top of linux-next (the patches also apply onto the
    current Linus' git tree, fwiw).
    - Dropped sparse fixes patch, as the issue appears to be already
    fixed in linux-next.
    - Addressed Sergei's comments on ahci_platform driver.

    Thanks,

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2


    \
     
     \ /
      Last update: 2010-03-03 18:19    [W:0.026 / U:0.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site