lkml.org 
[lkml]   [2010]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectsch_gpio: fix compilation warning "ignoring return value of gpiochip_remove"
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/gpio/sch_gpio.c | 25 +++++++++++++++++++++----
1 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/sch_gpio.c b/drivers/gpio/sch_gpio.c
index 761071a..a89c02d 100644
--- a/drivers/gpio/sch_gpio.c
+++ b/drivers/gpio/sch_gpio.c
@@ -229,7 +229,12 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
return 0;

err_sch_gpio_resume:
- gpiochip_remove(&sch_gpio_core);
+ err = gpiochip_remove(&sch_gpio_core);
+ if (err) {
+ dev_err(&pdev->dev, "%s failed, %d\n",
+ "gpiochip_remove()", err);
+ return err;
+ }

err_sch_gpio_core:
release_region(res->start, resource_size(res));
@@ -240,11 +245,23 @@ err_sch_gpio_core:

static int __devexit sch_gpio_remove(struct platform_device *pdev)
{
+ int err_c, err_r;
struct resource *res;
if (gpio_ba) {
- gpiochip_remove(&sch_gpio_core);
- gpiochip_remove(&sch_gpio_resume);
-
+ err_c = gpiochip_remove(&sch_gpio_core);
+
+ err_r = gpiochip_remove(&sch_gpio_resume);
+
+ if (err_c) {
+ dev_err(&pdev->dev, "%s failed, %d\n",
+ "gpiochip_remove()", err_c);
+ return err_c;
+ }
+ if (err_r) {
+ dev_err(&pdev->dev, "%s failed, %d\n",
+ "gpiochip_remove()", err_r);
+ return err_r;
+ }
res = platform_get_resource(pdev, IORESOURCE_IO, 0);

release_region(res->start, resource_size(res));
--
1.6.3.3


\
 
 \ /
  Last update: 2010-03-03 10:35    [W:0.428 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site