lkml.org 
[lkml]   [2010]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/6] hid: new driver for PicoLCD device
    On Sat, 27 Mar 2010, Bruno Prémont wrote:

    > +#ifdef CONFIG_PM
    > +static int picolcd_suspend(struct hid_device *hdev)
    > +{
    > + dbg_hid(PICOLCD_NAME " device ready for suspend\n");
    > + return 0;
    > +}
    > +
    > +static int picolcd_resume(struct hid_device *hdev)
    > +{
    > + return 0;
    > +}
    > +
    > +static int picolcd_reset_resume(struct hid_device *hdev)
    > +{
    > + int ret;
    > + ret = picolcd_reset(hdev);
    > + if (ret)
    > + dbg_hid(PICOLCD_NAME " resetting our device failed: %d\n", ret);
    > + return 0;
    > +}
    > +#endif
    [ ... ]
    > +static struct hid_driver picolcd_driver = {
    > + .name = "hid-picolcd",
    > + .id_table = picolcd_devices,
    > + .probe = picolcd_probe,
    > + .remove = picolcd_remove,
    > + .raw_event = picolcd_raw_event,
    > +#ifdef CONFIG_PM
    > + .suspend = picolcd_suspend,
    > + .resume = picolcd_resume,
    > + .reset_resume = picolcd_reset_resume,
    > +#endif
    > +};

    struct hid_driver doesn't provide power-management related callbacks. So I
    guess that you have either not tested this feature at all, or you have
    some extra patch somewhere which adds such callbacks to HID core, but you
    haven't sent it out for review?

    In any cases, this will very likely cause compilation failure with
    CONFIG_PM turned on.

    Thanks,

    --
    Jiri Kosina
    SUSE Labs, Novell Inc.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-29 11:49    [W:0.022 / U:30.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site