lkml.org 
[lkml]   [2010]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH tip/core/urgent] rcu: protect fork-time cgroup access
From
Date
On Mon, 2010-03-29 at 14:34 -0700, Paul E. McKenney wrote:

> And it appears that my patch is at best insufficient:
> http://paste.ubuntu.com/406189/
>
> Left to myself, I would wrap copy_process() with rcu_read_lock(),
> but I would rather hear your thoughts before doing too much more
> semi-random hacking. ;-)

Well, I don't think you can get away with that, copy_process() wants to
sleep on quite a few places ;-) Also, locks should be taken at the
smallest possible scope, unless we want to go back to BKL style
locking :-)

As to that freezer splat, you'd have to chase down the cgroup folks, I'm
fully ignorant on that.

For the set_task_rq() one, I'm afraid someone (which again I'm afraid
will be me) will have to look into how the task_group muck ties into the
cgroup muck as I think the original authors of that ran off :/





\
 
 \ /
  Last update: 2010-03-29 23:45    [W:0.036 / U:22.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site