Messages in this thread | | | Date | Mon, 29 Mar 2010 20:12:04 +0200 | From | Oleg Nesterov <> | Subject | [PATCH -mm 0/4] cputimers/proc: do_task_stat: don't walk through the thread list under ->siglock |
| |
On 03/29, Oleg Nesterov wrote: > > Yes sure. I dislike the do_task_stat() case because we always do this, > even if this info is not needed, say, for /bin/ps.
Note also that nobody else in /fs/proc needs ->siglock. Except do_io_accounting(), but in this case the user-space explicitly asks for this info.
OK, This is V2. Still RFC, although I think 1/4 makes sense in any case.
Please comment. Again, I am more or less sure these changes are "correct", but I don't know what /bin/top can think ;)
I don't really like the fact thread_group_times() takes cputimer.lock, but imho lock_task_sighand() in do_task_stat() is much worse.
Oleg.
| |