lkml.org 
[lkml]   [2010]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: linux-next: build warning after merge of the tree
    From
    Date
    On Sun, 2010-03-28 at 18:57 -0700, David Miller wrote:
    > From: Stephen Rothwell <sfr@canb.auug.org.au>
    > > After merging the tree, today's linux-next build (x86_64 allmodconfig)
    > > produced this warning:
    > > drivers/net/tulip/uli526x.c: In function 'uli526x_rx_packet':
    > > drivers/net/tulip/uli526x.c:861: warning: assignment makes pointer from integer without a cast
    > I just committed the following, let me know if it fixes
    > this.
    > - ((new_skb = dev_alloc_skb(rxlen + 2) != NULL))) {
    > + (((new_skb = dev_alloc_skb(rxlen + 2)) != NULL))) {

    You've an extra () there.

    A close paren could have been moved from after
    the NULL to after the "+ 2"

    I think it's more readable as:
    (new_skb = dev_alloc_skb(rxlen + 2))) {

    cheers, Joe



    \
     
     \ /
      Last update: 2010-03-29 04:19    [W:0.018 / U:93.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site