Messages in this thread | | | Date | Sun, 28 Mar 2010 22:55:14 +0200 | From | Andi Kleen <> | Subject | Re: [patch] drm: sysfs files error handling |
| |
, Dan Carpenter wrote: > > In the original code we used "j" as an iterator but we used "i" as an > index. > > - for (j = 0; j< i; j++) > - device_remove_file(&connector->kdev, > -&connector_attrs[i]);
I guess this really should be a attribute group anyways?
Typically when there's such a open coded loop it means the wrong interfaces are being used.
-Andi
| |