lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ext3: call blkdev_issue_flush on fsync
    From
    Date
    Please ignore this patch! Sorry for this!

    Warm Regards,
    Surbhi.

    On Fri, 2010-03-26 at 18:50 +0200, Surbhi Palande wrote:
    > To ensure that bits are truly on-disk after an fsync,
    > we should call blkdev_issue_flush if barriers are supported.
    >
    > This code is seen in ext4 through commits
    > d755fb384250d6bd7fd18a0930e71965acc8e72e and
    > 5f3481e9a80c240f169b36ea886e2325b9aeb745.
    >
    > Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
    > ---
    > fs/ext3/fsync.c | 4 ++++
    > 1 files changed, 4 insertions(+), 0 deletions(-)
    >
    > diff --git a/fs/ext3/fsync.c b/fs/ext3/fsync.c
    > index d336341..2184a40 100644
    > --- a/fs/ext3/fsync.c
    > +++ b/fs/ext3/fsync.c
    > @@ -29,6 +29,7 @@
    > #include <linux/jbd.h>
    > #include <linux/ext3_fs.h>
    > #include <linux/ext3_jbd.h>
    > +#include <linux/blkdev.h>
    >
    > /*
    > * akpm: A new design for ext3_sync_file().
    > @@ -46,6 +47,7 @@ int ext3_sync_file(struct file * file, struct dentry *dentry, int datasync)
    > {
    > struct inode *inode = dentry->d_inode;
    > int ret = 0;
    > + journal_t *journal = EXT3_SB(inode->i_sb)->s_journal;
    >
    > J_ASSERT(ext3_journal_current_handle() == NULL);
    >
    > @@ -87,5 +89,7 @@ int ext3_sync_file(struct file * file, struct dentry *dentry, int datasync)
    > ret = sync_inode(inode, &wbc);
    > }
    > out:
    > + if (journal && (journal->j_flags & JFS_BARRIER))
    > + blkdev_issue_flush(inode->i_sb->s_bdev, NULL);
    > return ret;
    > }




    \
     
     \ /
      Last update: 2010-03-26 20:57    [W:0.021 / U:0.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site