lkml.org 
[lkml]   [2010]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/16] Tools perf probe-finder.c: duplicated include
KOSAKI Motohiro wrote:
>> Hi Andrea,
>>
>> Andrea Gelmini wrote:
>>> tools/perf/util/probe-finder.c: string.h is included more than once.
>>
>> Would you mean that <string.h> and "string.h" are duplicated?
>> If so, NAK, sorry. Those are different, <string.h> is for
>> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
>>
>> Thank you,
>
> I think this discussion suggested "string.h" should be renameed more review
> friendly name. probably.

Hmm, we'd better review files under tools/utils/include too. :(
(not sure why we have those files, because some files includes
headers from original include directory, as like as
"../../include/linux/blahblah.h")

Thank you,

--
Masami Hiramatsu
e-mail: mhiramat@redhat.com


\
 
 \ /
  Last update: 2010-03-26 16:47    [W:0.077 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site