Messages in this thread | | | Date | Thu, 25 Mar 2010 20:15:54 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/6] sched/cpusets fixes, more changes are needed |
| |
On 03/25, Peter Zijlstra wrote: > > Yeah, such a smaller patch might work too, but I was trying to remove > some more of the complexity we grown. > > Being able to fully remove that TASK_WAKING check from task_rq_lock() > and only have it in set_cpus_allowed_ptr() would reduce some fast-path > logic.
OK. Agreed.
> You patch add a memory barrier and an unlock_wait(), which, while > seemingly correct, are harder to parse than the modified locking.
Yes, lock + set WAKING + unlock is simpler and cleaner, but this doesn't matter.
I think your patch should address all problems.
Oleg.
| |