lkml.org 
[lkml]   [2010]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
From
From: Karsten Keil <isdn@linux-pingi.de>
Date: Thu, 25 Mar 2010 13:13:18 +0100

> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
>> Compiling this driver gave a section mismatch,
>> so I reviewed the init/exit paths of the driver
>> and made the correct changes.
>>
>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>> in reference from the function sedlbauer_config() to the function
>> .devinit.text:hisax_init_pcmcia()
>> The function sedlbauer_config() references
>> the function __devinit hisax_init_pcmcia().
>> This is often because sedlbauer_config lacks a __devinit
>> annotation or the annotation of hisax_init_pcmcia is wrong.
>>
>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> Acked-by: <keil@b1-systems.de>
>
> Thank you for fixing this.

Thanks for reviewing Karsten.

Please put your proper name in your ACK lines in the
future, they should look just like Signed-off-by: lines.

I fixed this up when committing, thanks again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-03-25 20:01    [W:0.094 / U:1.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site