Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fat: fix buffer overflow in vfat_create_shortname() | Date | Thu, 25 Mar 2010 21:52:12 +0900 |
| |
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> Nikolaus Schulz <microschulz@web.de> writes: > >>> However, anyway, your patch is much better off than current one. So, >>> I'll apply this in the next merge window. >>> >>> Or should we apply this immediately? >>> >>> Thanks. >> >> Given that this fixes a stack corruption which triggers the gcc stack >> smashing protection and thus basically a crash, I vote for not >> postponing it, but applying it immediately. > > Um..., where is a stack corruption? sprintf() overflow? But, it's > actually snprintf(), not sprintf()...
Whoops, it was really sprintf(). -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |