lkml.org 
[lkml]   [2010]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
    Hi Henrik,

    thanks for the work. Please, just keep the placement of those attributes
    consistent. Otherwise it might be easy to miss:

    > -static int sedlbauer_config(struct pcmcia_device *link);
    > +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;

    Wrong.

    > -static int sedlbauer_probe(struct pcmcia_device *link)
    > +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
    > {

    Right.

    (I think checkpatch checks for this, too)

    Regards,

    Wolfram

    --
    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-03-25 13:19    [W:0.026 / U:0.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site