lkml.org 
[lkml]   [2010]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH -v3 1/2] lmb: seperate region array from lmb_region struct
From
Date
On Tue, 2010-03-23 at 11:42 +0100, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > void __init lmb_init(void)
> > {
> > + lmb.memory.region = lmb_memory_region;
> > + lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
> > + lmb.reserved.region = lmb_reserved_region;
> > + lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
> > +
>
> That's rather unreadable and has random whitespace noise.
>
> Should be something like:
>
> lmb.memory.region = lmb_memory_region;
> lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
> lmb.reserved.region = lmb_reserved_region;
> lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
>
> also, i'd suggest to shorten region_array_size to region_size (we know it's an
> array), so it would become:

I dislike those arrays anyways. See my other message about turning them
into lists, which would get rid of capacity constraints completely. What
do you think ?

Cheers,
Ben.




\
 
 \ /
  Last update: 2010-03-24 05:49    [W:0.110 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site