lkml.org 
[lkml]   [2010]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/11] Memory compaction core
    Hi Jonathan,

    On Wed, Mar 24, 2010 at 02:59:46PM -0600, Jonathan Corbet wrote:
    > On Wed, 24 Mar 2010 13:33:47 -0700
    > Andrew Morton <akpm@linux-foundation.org> wrote:
    >
    > > > + VM_BUG_ON(cc == NULL);
    > >
    > > It's a bit strange to test this when we're about to oops anyway. The
    > > oops will tell us the same thing.
    >
    > ...except that we've seen a fair number of null pointer dereference
    > exploits that have told us something altogether different. Are we
    > *sure* we don't want to test for null pointers...?

    Examples? Maybe WARN_ON != oops, but VM_BUG_ON still an oops that is
    and without serial console it would go lost too. I personally don't
    see how it's needed. Plus those things are mostly for debug to check
    for invariant condition, how long it takes to sort it out isn't very
    relevant. So I'm on Andrew camp ;).


    \
     
     \ /
      Last update: 2010-03-24 22:23    [W:2.689 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site