lkml.org 
[lkml]   [2010]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/11] Memory compaction core
    On Wed, 24 Mar 2010 14:59:46 -0600
    Jonathan Corbet <corbet@lwn.net> wrote:

    > On Wed, 24 Mar 2010 13:33:47 -0700
    > Andrew Morton <akpm@linux-foundation.org> wrote:
    >
    > > > + VM_BUG_ON(cc == NULL);
    > >
    > > It's a bit strange to test this when we're about to oops anyway. The
    > > oops will tell us the same thing.
    >
    > ...except that we've seen a fair number of null pointer dereference
    > exploits that have told us something altogether different. Are we
    > *sure* we don't want to test for null pointers...?
    >

    It's hard to see what the test gains us really - the kernel has
    zillions of pointer derefs, any of which could be NULL if we have a
    bug. Are we more likely to have a bug here than elsewhere?

    This one will oops on a plain old read, so it's a bit moot in this
    case.


    \
     
     \ /
      Last update: 2010-03-24 22:17    [W:0.022 / U:29.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site