lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] gpiolib: make names array and its values const
    Date
    gpiolib doesn't need to modify the names and I assume most initializers
    use string constants that shouldn't be modified anyhow.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Kevin Wells <kevin.wells@nxp.com>
    ---
    drivers/gpio/gpiolib.c | 2 +-
    drivers/gpio/pca953x.c | 2 +-
    include/asm-generic/gpio.h | 2 +-
    include/linux/i2c/pca953x.h | 2 +-
    4 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
    index 6d1b866..03e82d5 100644
    --- a/drivers/gpio/gpiolib.c
    +++ b/drivers/gpio/gpiolib.c
    @@ -720,7 +720,7 @@ int gpio_export(unsigned gpio, bool direction_may_change)
    unsigned long flags;
    struct gpio_desc *desc;
    int status = -EINVAL;
    - char *ioname = NULL;
    + const char *ioname = NULL;

    /* can't export until sysfs is available ... */
    if (!gpio_class.p) {
    diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
    index ab5daab..60553d0 100644
    --- a/drivers/gpio/pca953x.c
    +++ b/drivers/gpio/pca953x.c
    @@ -72,7 +72,7 @@ struct pca953x_chip {
    struct i2c_client *client;
    struct pca953x_platform_data *dyn_pdata;
    struct gpio_chip gpio_chip;
    - char **names;
    + const char *const *names;
    };

    static int pca953x_write_reg(struct pca953x_chip *chip, int reg, uint16_t val)
    diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
    index 979c6a5..bc0c14d 100644
    --- a/include/asm-generic/gpio.h
    +++ b/include/asm-generic/gpio.h
    @@ -98,7 +98,7 @@ struct gpio_chip {
    struct gpio_chip *chip);
    int base;
    u16 ngpio;
    - char **names;
    + const char *const *names;
    unsigned can_sleep:1;
    unsigned exported:1;
    };
    diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
    index d5c5a60..139ba52 100644
    --- a/include/linux/i2c/pca953x.h
    +++ b/include/linux/i2c/pca953x.h
    @@ -24,7 +24,7 @@ struct pca953x_platform_data {
    int (*teardown)(struct i2c_client *client,
    unsigned gpio, unsigned ngpio,
    void *context);
    - char **names;
    + const char *const *names;
    };

    #endif /* _LINUX_PCA953X_H */
    --
    1.7.0
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-23 11:27    [W:0.025 / U:28.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site