Messages in this thread | | | Subject | Re: [PATCH] arm: convert arm to arch_gettimeoffset() | From | john stultz <> | Date | Tue, 23 Mar 2010 17:49:02 -0700 |
| |
On Wed, 2010-03-24 at 00:34 +0000, Russell King wrote: > On Tue, Mar 23, 2010 at 04:05:21PM -0700, John Stultz wrote: > > Convert arm to use GENERIC_TIME via the arch_getoffset() infrastructure, > > reducing the amount of arch specific code we need to maintain. > > > > The arm architecture is the last arch that need to be converted. > > Much easier to merge, thanks. > > While looking for a machine to build-test this, I noticed that the IOP/IXP > platforms have ARCH_USES_GETTIMEOFFSET - yet they select PLAT_IOP which > in turn selects GENERIC_TIME etc. > > I think ARCH_IOP13XX, ARCH_IOP32X and ARCH_IOP33X shouldn't select > ARCH_USES_GETTIMEOFFSET - do you agree?
Oh, sorry! I didn't notice the PLAT_IOP was a superset of the IOP arches, thanks for catching that!
The generalized rule is: if they have clocksources, then you're right, ARCH_USES_GETTIMEOFFSET should not be used then (since it disables any non-jiffies clocksources from being used).
Do you need a new respin removing those lines, or are you comfortable modifying the patch already sent?
Thanks again for the review and help here! -john
| |