lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl
    Hi.

    On 24/03/10 11:21, Al Viro wrote:
    > On Wed, Mar 24, 2010 at 10:55:45AM +1100, Nigel Cunningham wrote:
    >> Hi again.
    >>
    >> On 24/03/10 10:52, Nigel Cunningham wrote:
    >>>> I've stayed away from TuxOnIce flamefests and I've no idea how
    >>>> representative
    >>>> that snippet is, but if it *does* match the general code quality in
    >>>> there...
    >>>> Ouch.
    >>>
    >>> Locking isn't necessary because of the freezing.
    >>
    >> Err, freezer, I mean.
    >
    > Even leaving aside the accuracy of that (and I seriously doubt it), this
    > is completely wrong since *code* *gets* *copied*.

    Ok. That's a fair enough point. I'll add locking.

    Regards,

    Nigel


    \
     
     \ /
      Last update: 2010-03-24 01:27    [W:0.019 / U:59.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site