lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH -v3 1/2] lmb: seperate region array from lmb_region struct
    On 03/23/2010 08:07 AM, Thomas Gleixner wrote:
    > On Tue, 23 Mar 2010, Yinghai Lu wrote:
    >
    >>
    >> lmb_init() connect them back.
    >>
    >> also add region_array_size in lmb_region to tack the region array size.
    >>
    >> -v3: seperate lmb core change to seperated patch
    >>
    >> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >>
    >> ---
    >> include/linux/lmb.h | 5 ++++-
    >> lib/lmb.c | 11 ++++++++++-
    >> 2 files changed, 14 insertions(+), 2 deletions(-)
    >>
    >> Index: linux-2.6/include/linux/lmb.h
    >> ===================================================================
    >> --- linux-2.6.orig/include/linux/lmb.h
    >> +++ linux-2.6/include/linux/lmb.h
    >> @@ -26,7 +26,8 @@ struct lmb_property {
    >> struct lmb_region {
    >> unsigned long cnt;
    >> u64 size;
    >> - struct lmb_property region[MAX_LMB_REGIONS+1];
    >> + struct lmb_property *region;
    >> + unsigned long region_array_size;
    >> };
    >>
    >> struct lmb {
    >> @@ -37,6 +38,8 @@ struct lmb {
    >> };
    >>
    >> extern struct lmb lmb;
    >> +extern struct lmb_property lmb_memory_region[MAX_LMB_REGIONS + 1];
    >> +extern struct lmb_property lmb_reserved_region[MAX_LMB_REGIONS + 1];
    >
    > Is there a reason why this needs to be exported ?
    >
    lmb_reserved_region is used in kernel/early_res.c::__check_and_double_early_res/subtract_early_res/early_res_to_bootmem

    later if those functions are moved lmb.c, we can make lmb_reserved_region to be static

    same thing to lmb_memory_region, that will be used by add_lmb_memory() later.

    YH





    \
     
     \ /
      Last update: 2010-03-23 18:43    [W:0.022 / U:32.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site