lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/11] Export unusable free space index via /proc/unusable_index
    On Tue, 23 Mar 2010, Mel Gorman wrote:

    > +/*
    > + * Return an index indicating how much of the available free memory is
    > + * unusable for an allocation of the requested size.
    > + */
    > +static int unusable_free_index(unsigned int order,
    > + struct contig_page_info *info)
    > +{
    > + /* No free memory is interpreted as all free memory is unusable */
    > + if (info->free_pages == 0)
    > + return 1000;


    Is that assumption correct? If you have no free memory then you do not
    know about the fragmentation status that would result if you would run
    reclaim and free some memory. Going into a compaction mode would not be
    useful. Should this not return 0 to avoid any compaction run when all
    memory is allocated?

    Otherwise

    Reviewed-by: Christoph Lameter <cl@linux-foundation.org>



    \
     
     \ /
      Last update: 2010-03-23 18:35    [W:4.172 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site