lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]I2C device - release cleanup
On Tue, 23 Mar 2010 13:02:41 +0000, jhautbois@gmail.com wrote:
> Hi Jean,
>
> < snip >
> > Did you test your patch? I am very skeptical that calling
>
> > single_release() out of the blue is the right thing to do. My instinct
>
> > tells me that single_release() is only meant for callers of
>
> > single_open().
>
> Well, using this call works fine with my hardware.
> I would say, as before :).
> Looking at the source code of single_release, this is very similar to what
> is done today.
>
> But yes, it would also be interesting to use single_open in the open()
> syscall.
> I think this would be nicer to use only single_*() functions.
>
> Maybe is it interesting to submit a patch that does a cleanup for all the
> i2c-dev file ? And not only the release function ?

Yes, that would be better. If you do that, please make sure to run your
patch through scripts/checkpatch.pl before sending it.

--
Jean Delvare


\
 
 \ /
  Last update: 2010-03-23 17:23    [W:1.839 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site