lkml.org 
[lkml]   [2010]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] cpufreq: Unify sysfs attribute definition macros
Date
On Tuesday 23 March 2010 13:05:34 Borislav Petkov wrote:
> From: Thomas Renninger <trenn@suse.de>
> Date: Tue, Mar 23, 2010 at 12:55:30PM +0100
>
> > > Well, struct freq_attr for example is cpufreq-specific attribute,
> > > AFAICT. So, keeping them in cpufreq.h should be fine, no?
> > You don't need much of these (one or two?).
>
> I don't think I get what you mean here..?
I expect you did this because you use it in your follow up patches, e.g.
+define_one_freq_rw(cpb);
If you don't want to argue about global names, but get your boost code
in quickly, just also duplicate the macro and if you have some time left
you could still do an on-top cleanup later.

Thomas


\
 
 \ /
  Last update: 2010-03-23 13:33    [W:0.164 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site