lkml.org 
[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
> On 2010-03-22 10:57, Pekka Enberg wrote:
> > On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@coyote.org> wrote:
> >> On 2010-03-22 08:16, Pekka Enberg wrote:
> >>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
> >>>
> >>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
> >>> see the same thing elsewhere in this patch as well.
> >>>
> >> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
> >> CamelCase alone for now. I can make it like that if you want..
> >
> > Yes please.
> >
>
>
> Here's a new patch against master that fixes CamelCase too.
>
>
>
> [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.
>
> I fixed the checkpatch things except a couple of long lines.
> I also removed hungarian notation and CamelCase from the argument names
> and some "commented away" code.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>

ACK.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2010-03-22 12:01    [W:0.532 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site