Messages in this thread | | | Date | Tue, 23 Mar 2010 10:33:49 +0800 | Subject | Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu | From | graff yang <> |
| |
On Mon, Mar 22, 2010 at 7:50 PM, David Howells <dhowells@redhat.com> wrote: > <graff.yang@gmail.com> wrote: > >> - return virt_to_page(addr); >> + return (struct page *) >> + (virt_to_page(addr)->index) ? : virt_to_page(addr); > > Can the extra conditional operator be made subject to CONFIG_SMP?
OK. Tejun is looking into the up layer percpu code. So I expecting there is better way to hook nommu in.
> >> - return page_to_pfn(virt_to_page(addr)); >> + return page_to_pfn((struct page *) >> + (virt_to_page(addr)->index) ? : virt_to_page(addr)); > > Ditto. > >> +#ifdef CONFIG_SMP >> ... >> +#endif > > Can this be put into a separate file? There's rather a lot in mm/nommu.c > these days. > > David >
-- -Graff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |