Messages in this thread Patch in this message | | | From | Jing Huang <> | Date | Mon, 22 Mar 2010 16:12:55 -0700 | Subject | RE: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr() |
| |
This is not intended. Using penable_rsp or pdisable_rsp in this case doesn't have functional difference since it is a union, but it is confusing and should be fixed.
Thanks
Jing
-----Original Message----- From: Roel Kluin [mailto:roel.kluin@gmail.com] Sent: Monday, March 22, 2010 1:49 PM To: Jing Huang; linux-scsi@vger.kernel.org; Andrew Morton; LKML Subject: [PATCH] bfa: wrong fcport H2I message tested in bfa_fcport_isr()
It appears that the wrong fcport H2I message was tested
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- Was this intended?
diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c index c589488..5e5e6fe 100644 --- a/drivers/scsi/bfa/bfa_fcport.c +++ b/drivers/scsi/bfa/bfa_fcport.c @@ -1281,7 +1281,7 @@ bfa_fcport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg) break; case BFI_FCPORT_I2H_DISABLE_RSP: - if (fcport->msgtag == i2hmsg.penable_rsp->msgtag) + if (fcport->msgtag == i2hmsg.pdisable_rsp->msgtag) bfa_sm_send_event(fcport, BFA_FCPORT_SM_FWRSP); break;
| |