[lkml]   [2010]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch v3] pcrypt: handle crypto_get_attr_type() errors
    I was concerned about the error handling for crypto_get_attr_type() in
    pcrypt_alloc_aead(). Steffen Klassert pointed out that we could simply
    avoid calling crypto_get_attr_type() if we passed the type and mask as a

    Signed-off-by: Dan Carpenter <>
    All three versions have basically been the same except for style issues.
    I will confess that this (hopefully final :P) version looks much nicer
    than the earlier ones.

    diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
    index 8020124..247178c 100644
    --- a/crypto/pcrypt.c
    +++ b/crypto/pcrypt.c
    @@ -315,16 +315,13 @@ out_free_inst:
    goto out;

    -static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb)
    +static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb,
    + u32 type, u32 mask)
    struct crypto_instance *inst;
    struct crypto_alg *alg;
    - struct crypto_attr_type *algt;
    - algt = crypto_get_attr_type(tb);

    - alg = crypto_get_attr_alg(tb, algt->type,
    - (algt->mask & CRYPTO_ALG_TYPE_MASK));
    + alg = crypto_get_attr_alg(tb, type, (mask & CRYPTO_ALG_TYPE_MASK));
    if (IS_ERR(alg))
    return ERR_CAST(alg);

    @@ -365,7 +362,7 @@ static struct crypto_instance *pcrypt_alloc(struct rtattr **tb)

    switch (algt->type & algt->mask & CRYPTO_ALG_TYPE_MASK) {
    - return pcrypt_alloc_aead(tb);
    + return pcrypt_alloc_aead(tb, algt->type, algt->mask);

    return ERR_PTR(-EINVAL);

     \ /
      Last update: 2010-03-22 16:31    [W:0.020 / U:85.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site